connectivity: Check for unexpected packet drops

[pchaigno]

This pull requests ensures we fail the connectivity tests if we hit any unexpected packet drops. The first commit transforms the existing missed-tail-call drops check into a new check for unexpected packet drops. The second commit defines a new flag to set the list of expected packet drop reasons. The last commit adds a bunch of packet drop reasons.

[tklauser]

LGTM apart from an open question on the new drop reasons CLI flag.

[brb]

Nice! Have you tried running /test on cilium/cilium after running git grep -l cilium_cli_ci_version: | xargs sed -i "s/cilium_cli_ci_version: .*/cilium_cli_ci_version: $CI_BUILD_VSN/g"?

[pchaigno]

Nice! Have you tried running /test on cilium/cilium after running git grep -l cilium_cli_ci_version: | xargs sed -i "s/cilium_cli_ci_version: .*/cilium_cli_ci_version: $CI_BUILD_VSN/g"?

No. But we have a flag to set the list of expected reasons, so we can adjust if specific tests need additional reasons.

[brb]

No. But we have a flag to set the list of expected reasons, so we can adjust if specific tests need additional reasons.

From my personal experience, I'd use it as a last resort. It's difficult to keep a mental map in a head of all options which need to be customized in each job X branches.

Also, if you don't test it now, then it might become someone else's problem once a new CLI version is released, and cilium/cilium's CLI dependency is bumped.

[pchaigno]

No. But we have a flag to set the list of expected reasons, so we can adjust if specific tests need additional reasons.

From my personal experience, I'd use it as a last resort. It's difficult to keep a mental map in a head of all options which need to be customized in each job X branches.

Agree. Either it's obvious (SRv6 drop in SRv6 workflow) or I'll update the default list.

Also, if you don't test it now, then it might become someone else's problem once a new CLI version is released, and cilium/cilium's CLI dependency is bumped.

I'm planning to update the CLI myself. I need this quickly.

[brb]

I tried running the change myself in cilium/cilium#29718, and most of the red builds are due to this check failing.

If we merge it now (or w/o trying it out), then this change will block other changes (which will be released together) from being used in the cilium/cilium CI.

[pchaigno]

I tried running the change myself in cilium/cilium#29718, and most of the red builds are due to this check failing.

I added those drop reasons.

If we merge it now (or w/o trying it out), then this change will block other changes (which will be released together) from being used in the cilium/cilium CI.

That's FUD given we have a flag to add other drop reason exceptions.

[michi-covalent]

the kind failure is tracked in #2162. merging 🚀🙏