Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't modify running cluster in dry-run mode #2166

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Don't modify running cluster in dry-run mode #2166

merged 2 commits into from
Dec 12, 2023

Commits on Dec 11, 2023

  1. install/upgrade: introduce IsDryRun method on parameters 

    Rather than open-coding the condition in various places.

Signed-off-by: Tobias Klauser <[email protected]>
    @tklauser @michi-covalent
    tklauser authored and michi-covalent committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    18f4eb9 View commit details
    Browse the repository at this point in the history

  2. install: don't make changes to running cluster in dry-run mode 

    In EKS mode, don't stop the AWS node DaemonSet when running in dry-run
mode. In AKS mode, don't create any cloud resources.

Signed-off-by: Tobias Klauser <[email protected]>
    @tklauser @michi-covalent
    tklauser authored and michi-covalent committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    872e533 View commit details
    Browse the repository at this point in the history