Make connectivity test pods terminate quickly #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
force-pushed
the
mio/quick-connectivity-test-pods-termination
branch
from
d696eb4
to
219dc39
Compare
Let's use the proper pause entrypoint, instead of sleep, so that the container reacts to signals and terminates immediately when the pod is deleted, instead of waiting for the expiration of the grace period. Signed-off-by: Marco Iorio <[email protected]>
giorio94
force-pushed
the
mio/quick-connectivity-test-pods-termination
branch
from
219dc39
to
f1a5b45
Compare
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use the proper pause entrypoint, instead of sleep, so that the container reacts to signals and terminates immediately when the pod is deleted, instead of waiting for the expiration of the grace period.
Related: cilium/alpine-curl#97