Drop cilium endpoint verification. #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktor-kurchenko
requested review from
nathanjsweet,
christarazi,
michi-covalent and
asauber
and removed request for
christarazi
asauber
requested changes
Dec 22, 2023
…t's disabled. Signed-off-by: viktor-kurchenko <[email protected]>
viktor-kurchenko
force-pushed
the
pr/vk/endpoint/crd/skip
branch
from
e7b166a
to
16344bf
Compare
asauber
approved these changes
Dec 27, 2023
viktor-kurchenko
changed the title
nathanjsweet
approved these changes
Jan 4, 2024
brlbil
approved these changes
Jan 5, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
joestringer
previously requested changes
Jan 5, 2024
maintainer-s-little-helper
bot
removed
the
ready-to-merge
joestringer
dismissed
their stale review
No need to block on my feedback. We can discuss a little more but I'm fine with the solution in principle.
maintainer-s-little-helper
bot
added
the
ready-to-merge
Signed-off-by: viktor-kurchenko <[email protected]>
joestringer
approved these changes
Jan 8, 2024
|
I think it would be useful to include the context in the description that: This is no longer needed because Cilium should be already provisioned correctly in the environment before deploying the connectivity apps, and these tests already validate that the k8s deployment resource is ready before continuing. |
viktor-kurchenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Cilium endpoint verification is no longer needed because Cilium should be already provisioned correctly in the environment before deploying the connectivity apps, and these tests already validate that the k8s deployment resource is ready before continuing.
This should also unblock connectivity tests for Customers that have
disableEndpointCRD: "true"property configured.