Improve cacheability of Docker layers and add ca-certs to scratch image #2842
Conversation
|
Commit 7f3f19e does not match "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Signed-off-by: Marco Franssen <[email protected]>
marcofranssen
force-pushed
the
fix-cilium-cli-image
branch
from
7f3f19e
to
6994eb4
Compare
|
Commit 7f3f19e does not match "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
|
Commit 018b43f does not match "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
marcofranssen
force-pushed
the
fix-cilium-cli-image
branch
from
018b43f
to
18a08a4
Compare
marcofranssen
force-pushed
the
fix-cilium-cli-image
branch
from
18a08a4
to
8a205de
Compare
| @@ -25,8 +25,10 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| include: | |||
| - name: cilium-cli | |||
| - name: cilium-cli-ci | |||
There was a problem hiding this comment.
This way we can leverage the target in docker build. as well don't need to append -ci in various places.
…fic image Signed-off-by: Marco Franssen <[email protected]>
marcofranssen
force-pushed
the
fix-cilium-cli-image
branch
from
8a205de
to
1602fe1
Compare
| LABEL maintainer="[email protected]" | ||
| WORKDIR /root/app |
There was a problem hiding this comment.
Moving this into the 2 target images cilium-cli and cilium-cli-ci makes it possible to cache these layers more efficiently meaning those layers will never have to be redownloaded as it is only the layers with binaries at the end that change.
There was a problem hiding this comment.
This seems like this change is partially reverting #2817, but it's not obvious to me why that PR introduced this FINAL_CONTAINER approach. Seems like we don't need this logic though, the developer could just run docker build --target cilium-cli .. This change looks good to me.
| LABEL maintainer="[email protected]" | ||
| WORKDIR /root/app |
There was a problem hiding this comment.
This seems like this change is partially reverting #2817, but it's not obvious to me why that PR introduced this FINAL_CONTAINER approach. Seems like we don't need this logic though, the developer could just run docker build --target cilium-cli .. This change looks good to me.
No description provided.