job: Validate job.OneShot name #10
Merged
+58
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @joamaki |
ovidiutirla
force-pushed
the
feature/validate-job-oneshot-name
branch
from
15f74e6 to
10486e3
Compare
joamaki
approved these changes
Sep 9, 2024
joamaki
requested changes
Sep 9, 2024
ovidiutirla
force-pushed
the
feature/validate-job-oneshot-name
branch
from
10486e3 to
f291110
Compare
Would you prefer to extract the fn as an common interface to avoid the |
”fn” is very specific to the job type and I can imagine we’d at some point have jobs that don’t take an ”fn”. I’d keep the ”fn” validation in the job constructor itself. |
Adds validation for job.OneShot, job.Timer, job.Observer to match regex `^[a-z][a-z0-9_\-]{0,30}$`. It avoids construction of jobs that are not usable for metrics.
Signed-off-by: Ovidiu Tirla <[email protected]>
ovidiutirla
force-pushed
the
feature/validate-job-oneshot-name
branch
from
f291110 to
d22a3f8
Compare
joamaki
approved these changes
Sep 10, 2024
ovidiutirla
added a commit
to ovidiutirla/cilium
that referenced
this pull request
Sep 11, 2024
The new version of hive have a new format for the job names to ensure the names are compliant with the prometheus metrics. This commit ensures that StateDB Reflector Job names are compliant with the new naming convention. See cilium/hive#10. Signed-off-by: Ovidiu Tirla <[email protected]>
ovidiutirla
added a commit
to ovidiutirla/cilium
that referenced
this pull request
Sep 11, 2024
The new version of hive have a new format for the job names to ensure the names are compliant with the prometheus metrics. This commit ensures that all jobs are compliant with the new naming convention. See cilium/hive#10. Signed-off-by: Ovidiu Tirla <[email protected]>
|
The max job name was bumped to 100. #14 |
ovidiutirla
added a commit
to ovidiutirla/cilium
that referenced
this pull request
Sep 11, 2024
The new version of hive have a new format for the job names to ensure the names are compliant with the prometheus metrics. This commit ensures that all jobs are compliant with the new naming convention. See cilium/hive#10. Signed-off-by: Ovidiu Tirla <[email protected]>
ovidiutirla
added a commit
to ovidiutirla/cilium
that referenced
this pull request
Sep 12, 2024
The new version of hive have a new format for the job names to ensure the names are compliant with the prometheus metrics. This commit ensures that StateDB Reflector Job names are compliant with the new naming convention. See cilium/hive#10. Signed-off-by: Ovidiu Tirla <[email protected]>
ovidiutirla
added a commit
to ovidiutirla/cilium
that referenced
this pull request
Sep 12, 2024
The new version of hive have a new format for the job names to ensure the names are compliant with the prometheus metrics. This commit ensures that all jobs are compliant with the new naming convention. See cilium/hive#10. Signed-off-by: Ovidiu Tirla <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 13, 2024
The new version of hive have a new format for the job names to ensure the names are compliant with the prometheus metrics. This commit ensures that StateDB Reflector Job names are compliant with the new naming convention. See cilium/hive#10. Signed-off-by: Ovidiu Tirla <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 13, 2024
The new version of hive have a new format for the job names to ensure the names are compliant with the prometheus metrics. This commit ensures that all jobs are compliant with the new naming convention. See cilium/hive#10. Signed-off-by: Ovidiu Tirla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation for job.OneShot to match regex
^[a-z][a-z0-9_\-]{0,30}$. It avoids construction of jobs that are not usable for metrics.