github: Run Docker build on all PRs #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the "build-image-release.yaml" such that runs for every pull request and commit to the `main` branch. This ensures the build is tested before the actual release. The credentials to push to quay.io are only available in the `release` deployment environment. This commit therefore changes the workflow to only use that environment if the workflow was triggered for a `v*` git tag. The `release` environment also needs approval from a Hubble maintainer, so the risk of accidentally pushing a release from a development branch is rather low. Signed-off-by: Sebastian Wicki <[email protected]>
gandro
added
🤖 area/CI
|
I have manually tested the "armed" release workflow on my fork, which successfully pushed to quay: https://github.com/gandro/hubble/actions/runs/8250692155/job/22565930550 |
chancez
approved these changes
Mar 12, 2024
rolinh
approved these changes
Mar 12, 2024
viktor-kurchenko
approved these changes
Mar 13, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the "build-image-release.yaml" such that runs for every pull request and commit to the
mainbranch. This ensures the build is tested before the actual release.The credentials to push to quay.io are only available in the
releasedeployment environment. This commit therefore changes the workflow to only use that environment if the workflow was triggered for av*git tag. Thereleaseenvironment also needs approval from a Hubble maintainer, so the risk of accidentally pushing a release from a development branch is rather low.