New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the vendor team from CODEOWNERS #1608

Merged

michi-covalent merged 1 commit into main from pr/michi/no-vendor

Oct 25, 2024

Collaborator

michi-covalent commented Oct 25, 2024

Now the only dependency is github.com/cilium/cilium ¹. Let's not pull in the vendor team for reviewing that.

https://github.com/cilium/hubble/blob/5fcb8c343b65fb894c820b7558387d69cbdde446/go.mod#L5 ↩


          Remove the vendor team from CODEOWNERS

181de05

Now the only dependency is github.com/cilium/cilium [^1]. Let's not pull
in the vendor team for reviewing that.

[^1]: https://github.com/cilium/hubble/blob/5fcb8c343b65fb894c820b7558387d69cbdde446/go.mod#L5

Signed-off-by: Michi Mutsuzaki <[email protected]>

michi-covalent added the release-note/misc label

michi-covalent requested review from a team as code owners

October 25, 2024 21:03

michi-covalent requested review from bimmlerd and removed request for a team

October 25, 2024 21:03

chancez approved these changes

View reviewed changes

michi-covalent merged commit fd0a385 into main

6 checks passed

michi-covalent deleted the pr/michi/no-vendor branch

October 25, 2024 23:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/misc