build: Add debug build step #1062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
force-pushed
the
pr/tammach/debug-image
branch
2 times, most recently
from
bd0283f to
a0eaff6
Compare
This is not optimal as the build is running twice, ideally, we can build with debug symbols and then strip later. Just for quick testing purpose. Signed-off-by: Tam Mach <[email protected]>
Signed-off-by: Tam Mach <[email protected]>
Signed-off-by: Tam Mach <[email protected]>
sayboras
force-pushed
the
pr/tammach/debug-image
branch
from
a0eaff6 to
6b001fa
Compare
Change error logs to IS_ENVOY_BUG to get a stack trace when a policy is destructed from a worker thread. Signed-off-by: Jarno Rajahalme <[email protected]>
Add patch to Envoy to release thread local slots first in the worker threads, and last in the main thread. This makes sure that destructors of shared resources are called from the main thread instead of a random worker thread. This fixes the issue where Cilium Network Policy Map was destructed from a main thread, possibly interfering with the Secret xDS gRPC protocol. Signed-off-by: Jarno Rajahalme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not optimal as the build is running twice, ideally, we can build with debug symbols and then strip later. Just for quick testing purpose.