Ingress policy enforcement v1.25 #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit f7871bb ] Flush on proxylib close so that any remaining data is not cut off. Signed-off-by: Jarno Rajahalme <[email protected]>
[ upstream commit 553af5a ] Add enforce_policy_on_l7_lb to bpf_metadata config to maintain backwards compatibility by explicitly turning on policy enforcement on Ingress to support older Cilium releases on the same Envoy build. Store the original source identity for enforcing ingress policy for Ingress, that otherwise only enforces the egress policy, as it operates on the egress path. Now both ingress and egress policies for the ingress identity are enforced when enforce_policy_on_l7_lb is configured as 'true'. Ingress arrives to Cilium nodes at node ports, which are meaningless for Cilium Network Policies. To remedy this the destination port of the selected backend is used also in ingress path policy enforcement. Note that this destination port may be different from the one the traffic was first received at the external load balancer. Signed-off-by: Jarno Rajahalme <[email protected]>
[ upstream commit ee919e1 ] Refactor Config::getMetadata() processing of L7 LB config to be more explicit and to error out on invalid config so that invalid traffic does not accidentally slip through. Adjust tests accordingly and add new tests to cover the new 'enforce_policy_on_l7lb' option. Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
force-pushed
the
ingress-policy-enforcement-v1.25
branch
from
48eb671
to
3639622
Compare
|
This might not require anymore once the below PRs are merged |
|
Closed in favor of #442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #351 on v1.25