tetragon: Factor persistent enforcement tests

Use sensor manager with the new KeepSensorsOnExit setup
instead of loading sensors manually.

Signed-off-by: Jiri Olsa <[email protected]>

pkg/sensors/tracing/enforcer_test.go

@@ -713,45 +713,53 @@ spec:
 	}
 }
 
+// We test following scenario:
+// - load enforcement policy
+// - 1st run of test binary, make sure enforcement policy is triggered
+// - simulate tetragon exit (with KeepSensorsOnExit)
+// - 2nd run of test binary, make sure enforcement policy is triggered
+// - remove bpffs directory
+// - 3rd run of test binary, no enforcement
 func testEnforcerPersistent(t *testing.T, builder func() *EnforcerSpecBuilder, expected, test string) {
 	testEnforcerCheckSkip(t)
 
 	if !bpf.HasLinkPin() {
 		t.Skip("skipping persistent enforcer test, link pin is not available")
 	}
 
+	ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
+	defer cancel()
+
+	tus.LoadSensor(t, base.GetInitialSensor())
+	path := bpf.MapPrefixPath()
+	mgr, err := sensors.StartSensorManager(path, true /* KeepSensorsOnExit */)
+	assert.NoError(t, err)
+
 	run := func(idx int, exp string) {
 		cmd := exec.Command(test, "0xfffe")
 		err := cmd.Run()
 
+		t.Logf("Run %s: %v\n", cmd, err)
 		if err == nil || err.Error() != exp {
 			t.Fatalf("run %d: Wrong error '%v' expected '%s'", idx, err, exp)
 		}
 	}
 
-	yaml := builder().WithoutMultiKprobe().MustYAML()
-	configHook := []byte(yaml)
-	err := os.WriteFile(testConfigFile, configHook, 0644)
-	if err != nil {
-		t.Fatalf("writeFile(%s): err %s", testConfigFile, err)
-	}
-
-	option.Config.KeepSensorsOnExit = true
-	defer func() { option.Config.KeepSensorsOnExit = false }()
+	tp, err := builder().WithoutMultiKprobe().Build()
+	assert.NoError(t, err)
 
-	sens, err := observertesthelper.GetDefaultSensorsWithFile(t, testConfigFile, tus.Conf().TetragonLib, observertesthelper.WithMyPid())
-	if err != nil {
-		t.Fatalf("GetDefaultObserverWithFile error: %s", err)
-	}
+	err = mgr.AddTracingPolicy(ctx, tp)
+	assert.NoError(t, err)
 
 	// first run - sensors are loaded, we should get kill/override
 	run(1, expected)
 
-	sensi := make([]sensors.SensorIface, 0, len(sens))
-	for _, s := range sens {
-		sensi = append(sensi, s)
-	}
-	sensors.UnloadSensors(sensi)
+	// Remove all servers - simulate tetragon exit with KeepSensorsOnExit
+	mgr.RemoveAllSensors(ctx)
+
+	// bpf pinned links removal is asynchronous, we need to wait to be sure it's gone
+	// (if for some reason it's gone)
+	time.Sleep(2 * time.Second)
 
 	// second run - sensors are unloaded, but pins stay, we should get kill/override
 	run(2, expected)