Update README.md

[baibhavKumar1]

debugged broken link

[mtardy]

Thanks for the patch! However, it looks like your commit is not signed-off, to improve tracking of who did what, the Tetragon project uses a "sign-off" procedure which you can learn more about in the Cilium project documentation.

Concretely it consists of adding your real name and an email address to your git config and using git commit -s to write your commit message. You can use git commit --amend -s to add the signature to existing commits.

See more details on how to comply with the "sign-off" procedure

To add your name and email to your git config:

git config user.email "[email protected]"
git config user.name "firstname lastname"

Note: add the --global flag after config to configure this by default for repositories on your host.

Then you can use for new commits:

git commit -s

Or for existing commits on which you want to add the signed-off-by statement:

git commit --amend -s

For more information, see this extract from git-commit(1) man page regarding the -s flag:

-s, --signoff, --no-signoff
   Add a Signed-off-by trailer by the committer at the end of the commit log
   message. The meaning of a signoff depends on the project to which you're
   committing. For example, it may certify that the committer has the rights to
   submit the work under the project's license or agrees to some contributor
   representation, such as a Developer Certificate of Origin. (See
   http://developercertificate.org for the one used by the Linux kernel and Git
   projects.) Consult the documentation or leadership of the project to which
   you're contributing to understand how the signoffs are used in that project.

   The --no-signoff option can be used to countermand an earlier --signoff
   option on the command line.

Can you also write your commit message with something like README: fix tracing policy doc broken link

[mtardy]

Can you squash your 3 commits into one?

[baibhavKumar1]

Hi, sorry for the mess, can you please help me with that.

[mtardy]

Still we need a real name in the author and signature field.

[baibhavKumar1]

What needs to be done for that? My name is "Baibhav" , but I don't have github account with that name.

[mtardy]

Please take a look at this again:

Thanks for the patch! However, it looks like your commit is not signed-off, to improve tracking of who did what, the Tetragon project uses a "sign-off" procedure which you can learn more about in the Cilium project documentation.

Concretely it consists of adding your real name and an email address to your git config and using git commit -s to write your commit message. You can use git commit --amend -s to add the signature to existing commits.

See more details on how to comply with the "sign-off" procedure

To add your name and email to your git config:

git config user.email "[email protected]"
git config user.name "firstname lastname"

Note: add the --global flag after config to configure this by default for repositories on your host.

Then you can use for new commits:

git commit -s

Or for existing commits on which you want to add the signed-off-by statement:

git commit --amend -s

For more information, see this extract from git-commit(1) man page regarding the -s flag:

-s, --signoff, --no-signoff
   Add a Signed-off-by trailer by the committer at the end of the commit log
   message. The meaning of a signoff depends on the project to which you're
   committing. For example, it may certify that the committer has the rights to
   submit the work under the project's license or agrees to some contributor
   representation, such as a Developer Certificate of Origin. (See
   http://developercertificate.org for the one used by the Linux kernel and Git
   projects.) Consult the documentation or leadership of the project to which
   you're contributing to understand how the signoffs are used in that project.

   The --no-signoff option can be used to countermand an earlier --signoff
   option on the command line.

[baibhavKumar1]

I did the signature and commit message in last commit but then I did git push, is it required? Or just

git commit --amend --no-edit -s

will do?

[jrfastab]

@Wholesomebruh hi! patch looks good just need a real name on the signed off by. I think to do this open your .gitconfig and change the name to a real name. And then do the git commit --ammend -s and push again and should be good to go.

[mtardy]

Fixed by #1270.