Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Helm chart values doc to docs reference #1288

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Jul 28, 2023

Fixes #1287

@mtardy mtardy added the area/documentation Improvements or additions to documentation label Jul 28, 2023
@mtardy mtardy requested a review from a team as a code owner July 28, 2023 18:01
@mtardy mtardy requested a review from tpapagian July 28, 2023 18:01
@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 9e25761
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/64c40281d40dae000841980b
😎 Deploy Preview https://deploy-preview-1288--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tixxdz tixxdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, thanks

@@ -0,0 +1,104 @@
---
title: "Helm chart"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this: Kubernetes Helm chart , so it is clear for everyone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, however, I don't agree, what is a non-Kubernetes helm chart? I try to keep it short for the summary navbar on the left and don't want to introduce unnecessary stuff.

@mtardy mtardy merged commit 59a9e08 into main Aug 2, 2023
28 checks passed
@mtardy mtardy deleted the pr/mtardy/helm-docs branch August 2, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a reference page generated from the helm chart values
2 participants