Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Deprecate Pod.labels field #1363

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

michi-covalent
Copy link
Contributor

Deprecate Pod.labels field which contains Cilium identity labels, and document that it has been replaced by Pod.pod_labels field.

Ref: #794

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 0235473
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/64dd4e4e819dce0007d3f07c
😎 Deploy Preview https://deploy-preview-1363--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Deprecate Pod.labels field which contains Cilium identity labels, and
document that it has been replaced by Pod.pod_labels field.

Ref: #794

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent marked this pull request as ready for review August 16, 2023 23:13
@michi-covalent michi-covalent requested review from mtardy and a team as code owners August 16, 2023 23:13
@kkourt
Copy link
Contributor

kkourt commented Aug 17, 2023

CC: @rolinh @kaworu

Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michi-covalent michi-covalent merged commit 7474022 into main Aug 17, 2023
28 checks passed
@michi-covalent michi-covalent deleted the pr/michi/deprecation-struggle branch August 17, 2023 22:39
michi-covalent added a commit that referenced this pull request Sep 5, 2023
Pod.Labels field got deprecated in v0.11 [^1], so we can stop setting the
field in main branch. This means that Tetragon no longer depends on
the Cilium state, so we don't have to synchronize it anymore. This patch
removes tetragon.enableCiliumAPI Helm value and deletes packages related
to Cilium state synchronization.

[^1]: #1363

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this pull request Sep 6, 2023
Pod.Labels field got deprecated in v0.11 [^1], so we can stop setting the
field in main branch. This means that Tetragon no longer depends on
the Cilium state, so we don't have to synchronize it anymore. This patch
removes tetragon.enableCiliumAPI Helm value and deletes packages related
to Cilium state synchronization.

[^1]: #1363

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this pull request Dec 6, 2023
The pod.labels field got deprecated in v1.0. Let's remove it for v1.1.

Ref: #1363

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this pull request Dec 6, 2023
The pod.labels field got deprecated in v1.0. Let's remove it for v1.1.

Ref: #1363

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this pull request Dec 6, 2023
The pod.labels field got deprecated in v1.0. Let's remove it for v1.1.

Ref: #1363

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this pull request Dec 6, 2023
The pod.labels field got deprecated in v1.0. Let's remove it for v1.1.

Ref: #1363

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this pull request Dec 6, 2023
The pod.labels field got deprecated in v1.0. Let's remove it for v1.1.

Ref: #1363

Signed-off-by: Michi Mutsuzaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants