sensors: modify unload hooks and remove GetConfig and SetConfig #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnloadHook is called before the programs and maps are being removed. In preparation to the addition of a PostUnloadHook, we rename the hook to PreUnloadHook to be more explicit. Signed-off-by: Mahe Tardy <[email protected]>
This hook is a complement to PreUnloadHook freshly renamed in previous commit. It is intended to replace Ops.Unloaded to be called at the sensor level and not the collection level. Signed-off-by: Mahe Tardy <[email protected]>
This operation was replaced with previous commit's PostUnloadHook and is now directly called from *Sensor.Unload instead of collection caller. Signed-off-by: Mahe Tardy <[email protected]>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mtardy
requested review from
kkourt and
kevsecurity
and removed request for
tixxdz
This removes the Ops Operations field on the Sensor struct since it's no longer needed. It removes the Loaded hook that was called at a collection of sensor loading time. We can add LoadHook (similarly as Pre and Post UnloadHook) in the future if it's needed again. It removes GetConfig and SetConfig along and removes those functions from the API since they were already not used, see this note: > NB: sensorConfigSet was used before tracing policies were > introduced. The idea was that it could be used to provide > sensor-specifc configuration values. We can either modify the > call to specify a sensor within a collection, or completely > remove it. TBD. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/cleanup-generic-sensor
branch
from
06fef18
to
321be09
Compare
Previously, we kept all the unloaded kprobe entries in the generic kprobe table forever, never calling RemoveEntry. This patch uses PostUnloadHook to cleanup the entry from the table at unload time, other cleanups could be performed there if needed. Signed-off-by: Mahe Tardy <[email protected]>
kkourt
reviewed
Aug 24, 2023
kkourt
approved these changes
Aug 24, 2023
Thanks will add a test in this PR! |
Signed-off-by: Mahe Tardy <[email protected]>
Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/cleanup-generic-sensor
branch
from
df0e1ce
to
2b74b4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits, the last one removes a deprecated and unused thing in sensors.
These patches were made in order for us (me) to be able to use
PostUnloadHooklater on.