Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more resources #1434

Closed
wants to merge 1 commit into from
Closed

Added more resources #1434

wants to merge 1 commit into from

Conversation

saintdle
Copy link
Contributor

@saintdle saintdle commented Sep 5, 2023

Added more blogs, new videos section,

@saintdle saintdle requested review from mtardy and a team as code owners September 5, 2023 15:41
@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 61a4895
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/64f853ba862c780008633690
😎 Deploy Preview https://deploy-preview-1434--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, just a little nit!

@mtardy mtardy added the area/documentation Improvements or additions to documentation label Sep 5, 2023
@saintdle
Copy link
Contributor Author

saintdle commented Sep 6, 2023

Thanks a lot, just a little nit!

done

@mtardy
Copy link
Member

mtardy commented Sep 6, 2023

Thanks a lot, just a little nit!

done

Thanks a lot, can you squash those two commits with a message like docs: added new external resources

@mtardy mtardy added the release-note/docs This PR updates the documentation. label Sep 7, 2023
@@ -24,11 +24,21 @@ description: "Additional resources to learn about Tetragon"

### Blog posts

[Can I Use Tetragon without Cilium? Yes!](https://isovalent.com/blog/post/can-i-use-tetragon-without-cilium-yes/) - [Dean Lewis](https://twitter.com/saintdle), 2023
Copy link
Member

@mtardy mtardy Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Can I Use Tetragon without Cilium? Yes!](https://isovalent.com/blog/post/can-i-use-tetragon-without-cilium-yes/) - [Dean Lewis](https://twitter.com/saintdle), 2023
[Can I Use Tetragon without Cilium? Yes!](https://isovalent.com/blog/post/can-i-use-tetragon-without-cilium-yes/) - Dean Lewis, 2023

For some reason, Twitter is making the link checker timeout and I would not rely on Twitter from now on... Is it okay if we remove this link?

"url": "https://twitter.com/saintdle",
        "status": {
          "text": "Timeout"
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think link is still there https://github.com/cilium/tetragon/compare/63f2051b9d32b8ecf47566b835759d09435a9df1..302b6b6978651e4bdae17d4759227860363e43f2 you just changed your commit message. I think you might have forgot to git add sorry I skipped that in the process. You need a blank line before the "Signed-off" thingie as well.

Added more blogs, new videos section.
- removed link to twitter
Signed-off-by: Dean <[email protected]>
@saintdle saintdle closed this by deleting the head repository Sep 8, 2023
@mtardy
Copy link
Member

mtardy commented Sep 8, 2023

Hey do you need help? Sorry I don't want to make the process tedious for such a small modification, I can help you if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants