Commits on Apr 11, 2024

1. redaction: fix crash related to redaction filters + improve performance …

   [upstream commit: 91012a8]
   
   The previous redaction filters implementation was unsound, as it made modifications to the
   process object within an event message, but this object was already being shared in the
   event cache. This caused a data race that in turn resulted in a frequent crash when
   applying redaction filters on a modest workload. Moreover, the prior implementation was
   not very performant, since it relied on iterating over all fields in an event message to
   redact strings. In practice, we only really care about arguments in the majority of use
   cases.
   
   To address the above issues, we make a small breaking change in how the redaction filters
   work to focus ONLY on arguments and apply them much earlier in the pipeline. This both
   fixes the crash and significantly reduces performance impact, while solving the primary
   use case.
   
   Signed-off-by: William Findlay <[email protected]>

   

   willfindlay committed Apr 11, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 692d42a
   • Browse repository at this point

   Copy the full SHA

   692d42a View commit details

   Browse the repository at this point in the history