api: revert breaking change in proto #2332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfindlay
added
the
release-note/bug
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
willfindlay
force-pushed
the
pr/willfindlay/revert-breaking-api-change
branch
from
89700d7
to
cf341b4
Compare
Commit b6d3583 introduced a breaking change in our protobuf API by renaming the existing stack_trace field in the kprobe message to kernel_stack_trace when introducing user stack traces. While a change of this nature is not ordinarily problematic in protocol buffer APIs, it is an issue for Tetragon specifically since we rely on protojson for event exports. This effectively means that renaming a field breaks compatibility for downstream consumers of event exports. Revert the rename to prevent breakages. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/revert-breaking-api-change
branch
from
cf341b4
to
6ab0d82
Compare
michi-covalent
approved these changes
Apr 12, 2024
mtardy
approved these changes
Apr 12, 2024
|
After some discussion offline, we determined that in this case the breakage is probably ok because of the nature of the feature. If this is not the case for someone, I'd be happy to hear an argument to reopen this. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b6d3583 introduced a breaking change in our protobuf API by renaming the existing stack_trace field in the kprobe message to kernel_stack_trace when introducing user stack traces. While a change of this nature is not ordinarily problematic in protocol buffer APIs, it is an issue for Tetragon specifically since we rely on protojson for event exports. This effectively means that renaming a field breaks compatibility for downstream consumers of event exports. Revert the rename to prevent breakages.