tetragon: Load base sensor via sensor manager #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
olsajiri
added
the
release-note/minor
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
10 times, most recently
from
fdbff84
to
979a87a
Compare
kkourt
reviewed
Oct 31, 2024
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
2 times, most recently
from
a963a86
to
4aace87
Compare
We already lock access to the collections and we depend on the queue serialize policy/sensor loads/unloads. Following change will remove the queue, but we still want to keep the loads/unloads serialized, so adding lock for that. Signed-off-by: Jiri Olsa <[email protected]>
Removing go routine from sensor manager and calling the handler routines directly. Aslo removing LoadArg/UnloadArg types, which do not seem to be used anymore. Signed-off-by: Jiri Olsa <[email protected]>
Removing channel setup from sensor manager functions, because with go routine removed there's no longer need for that. Signed-off-by: Jiri Olsa <[email protected]>
Moving policyLister under sensor manager handler to keep all the handler routines together now that we don't have the go routine. Signed-off-by: Jiri Olsa <[email protected]>
Loading initial sensor via sensor manager so it stores all the loaded sensors/programs. So far we kept it separated but having it in one place is handy for metrics requesting this data. Moving the load before the server is started so we don't need to "wait" for that. This way we can remove the sensorMgWait channel. Signed-off-by: Jiri Olsa <[email protected]>
We removed the go routine, so it's no longer needed. Signed-off-by: Jiri Olsa <[email protected]>
Now we removed StopSensorManager call from getTestSensorManager we no longer need it to have the ctx argument. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
4aace87
to
de29d49
Compare
mtardy
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading initial sensor via sensor manager so it stores all the
loaded sensors/programs. So far we kept it separated but having
it in one place is handy for metrics requesting this data.
plus related fixes