Remove fallback replies & implement intentional mentions #2138
+80
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes fallback replies from messages, and additionally adds
m.mentions
support to Cinny.Fallback replies simply just aren't used anymore, and
m.mentions
works by iterating through the children of the composer to find where tabbed-in mentions have been used, and adds those to the mentions dictionary.This means that cinny no longer accidentally pings anyone who was mentioned in messages that are being replied to.
Fixes #1544
Type of change
Checklist: