Add a dark theme and dark theme syntax highlight colors #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done using Web Developer Tools in Firefox
|
Fixed the contrast fails in the code highlighting by making the comments a lighter gray and the code highlight background darker (but not as dark as the body background)
|
|
is this opt-in or the new default theme? |
@hamnis according to this in the Laika docs The operating system settings are what prompts the site to be in dark or light mode, and I have confirmed this works on this branch. |
|
The contrast on the light theme doesn't have the fix from the earlier PR, but here is a demo of switching @hamnis Screen.Recording.2025-01-03.at.12.06.25.PM.mov |
hamnis
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it looks nice 😃
Edit: updated the screenshot to latest version