Use native ARM runners when testing on ARM architecture #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
improvement
jsf9k
force-pushed
the
improvement/use-native-arm-runners
branch
from
afd5051 to
b10d648
Compare
dv4harr10
approved these changes
Jan 21, 2025
dav3r
approved these changes
Jan 21, 2025
|
Note that the Fedora 40 and 41 checks are currently failing because of fedora-cloud/docker-brew-fedora#117. |
|
@cisagov/vm-dev - Do you think I should remove the QEMU and buildx jazz from this workflow? We're not using it, but it isn't doing any harm. |
If it's not causing any issues, I'm fine leaving it in. |
These failures are fixed by #216. |
This provides better and faster testing of ARM architectures than testing under QEMU emulation.
We are no longer emulating ARM under QEMU, so using this GitHub Action no longer causes the runners to run out of resources and crash.
jsf9k
force-pushed
the
improvement/use-native-arm-runners
branch
from
b10d648 to
7a3c694
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request:
build.ymlworkflow to use native ARM runners when testing on ARM architecture💭 Motivation and context
Resolves #211.
🧪 Testing
All automated tests pass. I also verified that the expected platforms are indeed tested via native ARM runners.
✅ Pre-approval checklist