Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit for curl based load generator #3

Merged
merged 2 commits into from
Dec 5, 2024
Merged

initial commit for curl based load generator #3

merged 2 commits into from
Dec 5, 2024

Conversation

noMoreCLI
Copy link
Contributor

@noMoreCLI noMoreCLI commented Dec 5, 2024 •
edited
Loading

Description

This is the cleaned up version of the curl based loader from apm-game

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Removed any AppDynamics references and dependencies

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@noMoreCLI noMoreCLI requested a review from a team as a code owner December 5, 2024 14:04
svrnm
svrnm requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments but looks good to me overall

build.sh Show resolved Hide resolved
build.sh Show resolved Hide resolved
loaders/curl/Dockerfile Outdated Show resolved Hide resolved
@svrnm svrnm merged commit 0037102 into main Dec 5, 2024
1 check failed
@svrnm svrnm deleted the curl_loader branch December 18, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noMoreCLI @svrnm