#56 Changes to run mysql

[orousseau49170]

New version of mysql + activation of database service

Description

Please provide a meaningful description of what this change will do, or is for.
Bonus points for including links to related issues, other PRs, or technical
references.

Note that by not including a description, you are asking reviewers to do extra
work to understand the context of this change, which may lead to your PR taking
much longer to review, or result in it not being reviewed at all.

Type of Change

• [X ] Bugfix
• New Feature
• Breaking Change
• Refactor
• Documentation
• Other (please describe)

Checklist

• I have read the contributing guidelines
• Existing issues have been referenced (where applicable)
• I have verified this change is not present in other open pull requests
• Functionality is documented
• All code style checks pass
• New code contribution is covered by automated tests
• All new and existing tests pass

[svrnm]

thanks, I provided some feedback :-)

[noMoreCLI]

For the time being I‘m ok to merge it that way so that it works.

________________________________ From: Severin Neumann ***@***.***> Sent: Friday, December 20, 2024 10:37:42 AM To: cisco-open/app-simulator ***@***.***> Cc: Alexander Stoklasa (astoklas) ***@***.***>; Review requested ***@***.***> Subject: Re: [cisco-open/app-simulator] #56 Changes to run mysql (PR #58) @svrnm commented on this pull request.

________________________________ In src/databases/mysql/Dockerfile<#58 (comment)>:

@@ -1,9 +1,10 @@

-FROM mysql:5.7 +FROM --platform=linux/amd64 mysql:5.7 do we want to merge this one nevertheless to make it work for now? Although I am not 100% sure how the build pipeline will react on that platform parameter — Reply to this email directly, view it on GitHub<#58 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFKUM5OUHG6662N43P6F6B32GPQONAVCNFSM6AAAAABT5CNQO2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJXGE2DIMZYGM>. You are receiving this because your review was requested.Message ID: ***@***.***>

[noMoreCLI]

I think we should make the passwords configurable anyway. So that you can pass non default passwords to an app service and db‘s.

________________________________ From: Severin Neumann ***@***.***> Sent: Friday, December 20, 2024 10:53:53 AM To: cisco-open/app-simulator ***@***.***> Cc: Alexander Stoklasa (astoklas) ***@***.***>; Review requested ***@***.***> Subject: Re: [cisco-open/app-simulator] #56 Changes to run mysql (PR #58) @svrnm commented on this pull request.

________________________________ In examples/docker-compose.yml<#58 (comment)>:

@@ -37,17 +37,20 @@ services:

build: context: ../src/loaders/curl dockerfile: Dockerfile + environment: + - URLS=https://frontend:8080/addtocart http://frontend:8080/checkout + - SLEEP=5 + - WAIT=1 + backend-db: + image: ghcr.io/cisco-open/app-simulator-databases-mysql:latest + environment: + - MYSQL_ROOT_PASSWORD=root I wonder if we can set this in the dockerfile to a fixed value, so we don't need it here and also not in the generator — Reply to this email directly, view it on GitHub<#58 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFKUM5MR2T7HQCISTOAZAPL2GPSLDAVCNFSM6AAAAABT5CNQO2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJXGE3TSNJXGU>. You are receiving this because your review was requested.Message ID: ***@***.***>

[svrnm]

I think we should make the passwords configurable anyway. So that you can pass non default passwords to an app service and db‘s.

Yes, we should do that, but not sure if this is something we want to fix right now or later, because this should so be driven through the config file, so the config for a database should have something like

{
  rootPassword: "XYZ"
}

and then we add a script to /docker-entrypoint-initdb.d/ that reads the config and applies that change as well on container initalization.

[svrnm]

lgtm, thanks @orousseau49170 !