Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshots test #18
Snapshots test #18
Changes from all commits
b7ecdc8
12c26f6
e8a50dc
62d7fc2
397a77b
24a4058
6fa94b8
8654229
f6fcecc
362bef4
a7bbcc9
a0111a1
2b80fdf
d4ca530
d513bb6
7cc556b
9f9ae55
0feb7f0
caeb877
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with all these being static, it will not be possible to run more than one test client on a given system. I am not sure that is a good idea ... perhaps good enough for now, but prolly worth the small refactor to make then instance fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a big, but a feature - I want the data to persist client instance restart, so we can demonstrate how server side acks work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do ack's need timeouts? Is that something pulsar-like that we are trying to simulate? What is the concept of "visibility"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
|| []
will result in a phantom topic that is not tracked anywhereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we don't have TS to declare return type is promise, marking this method
async
may be a good idea for documenting that it returns a PromiseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use .find() here instead of findIndex