-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maker Cli testing #326
Maker Cli testing #326
Conversation
d6c0cb4
to
5278ff8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Just the lint fix its good to go.
refactor test_framework mod.rs to expose some common functions. some other changes in maker to make things consistent. Authored-by:mojoX911 <[email protected]>
5f23d2a
to
f5e8a19
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 74.34% 79.97% +5.62%
==========================================
Files 32 33 +1
Lines 4073 4908 +835
==========================================
+ Hits 3028 3925 +897
+ Misses 1045 983 -62 ☔ View full report in Codecov by Sentry. |
@mojoX911 It's ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean code. Great work.
This pr aims to move the work done in #311.