Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maker Cli testing #326

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Maker Cli testing #326

merged 2 commits into from
Dec 21, 2024

Conversation

KnowWhoami
Copy link
Collaborator

This pr aims to move the work done in #311.

  • It includes the original commits from that pr .
  • Addresses the review comments given in that pr.

Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Just the lint fix its good to go.

refactor test_framework mod.rs to expose some common functions.

some other changes in maker to make things consistent.

Authored-by:mojoX911 <[email protected]>
@KnowWhoami KnowWhoami force-pushed the maker-cli branch 3 times, most recently from 5f23d2a to f5e8a19 Compare December 20, 2024 07:13
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 80.72289% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.97%. Comparing base (09718c6) to head (f5e8a19).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/maker/rpc/server.rs 36.84% 12 Missing ⚠️
src/bin/directory-cli.rs 66.66% 1 Missing ⚠️
src/maker/server.rs 90.00% 1 Missing ⚠️
src/market/directory.rs 66.66% 1 Missing ⚠️
src/utill.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   74.34%   79.97%   +5.62%     
==========================================
  Files          32       33       +1     
  Lines        4073     4908     +835     
==========================================
+ Hits         3028     3925     +897     
+ Misses       1045      983      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KnowWhoami
Copy link
Collaborator Author

@mojoX911 It's ready.

Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean code. Great work.

@mojoX911 mojoX911 merged commit e690188 into citadel-tech:master Dec 21, 2024
14 checks passed
@KnowWhoami KnowWhoami deleted the maker-cli branch December 23, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Integration Test for Maker's RPC
2 participants