Remove bitcoin-core binaries from repo. #397
Conversation
This requirement we faced when we tried to publish the crate to crates.io. With this commit, we can download the bitcoin-core binary once based on system OS and there-on use it as cached.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
==========================================
+ Coverage 70.50% 70.76% +0.25%
==========================================
Files 34 34
Lines 4242 4242
==========================================
+ Hits 2991 3002 +11
+ Misses 1251 1240 -11 ☔ View full report in Codecov by Sentry. |
| Ok(res) if res.status_code == 503 => { | ||
| // If the response is 503, log and prepare for retry | ||
| eprintln!( | ||
| "Attempt {}: URL {} returned status code 503 (Service Unavailable)", |
There was a problem hiding this comment.
shouldn't it just be attempt since attempt is already starting from 1?
|
I am not seeing the point here. Downloading bitcoind is not a user-side requirement. We only needed the binary for testing. User will run their own node. Also this doesn't fix the github CI timeout issues for which we had the binary in the first place. |
This is only for testing, and the required crates added here are feature-gated. There is still a possibility of a GitHub timeout, but we can host the binary on our own server and download it from there if bitcoin.org is slow. However, including the binaries in the repository is not the right approach. I am prepared to modify the CI in case of GitHub Action timeouts. |
Lets do that. |
Closes: #396