Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create jime.csl #7394

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

xolotl
Copy link

@xolotl xolotl commented Jan 18, 2025

Creating a first version of a CSL file to support formatting references following the requirements of the Journal of Interactive Media in Education (JIME).

Creating a first version of a CSL file to support formatting references following the requirements of the Journal of Interactive Media in Education (JIME).
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"1365-893X"=>["jime", "jime"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"1365-893X" => ["jime", "jime"],

Please check the test report for details.

Removing eissn which duplicates issn.
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

jime.csl (new)
(CSL search by example 2012; Hancké et al. 2007)
(Fenner et al. 2019; Mares 2001)

CSL search by example. 2012. . . Available at http://editor.citationstyles.org/searchByExample/ [Last accessed 15 December 2012].
Fenner, M, Crosas, M, Grethe, JS, Kennedy, D, Hermjakob, H, Rocca-Serra, P, Durand, G, Berjon, R, et al.. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6(1):28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, B, Rhodes, M and Thatcher, M (eds). 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? In Varieties of capitalism. The institutional foundations of comparative advantage. Edited by PA Hall & D Soskice. New York: Oxford University Press:184–213.

Updating multiple editors/translators to use "and" rather than "&" following JIME requirements.
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

jime.csl (new)
(CSL search by example 2012; Hancké et al. 2007)
(Fenner et al. 2019; Mares 2001)

CSL search by example. 2012. . . Available at http://editor.citationstyles.org/searchByExample/ [Last accessed 15 December 2012].
Fenner, M, Crosas, M, Grethe, JS, Kennedy, D, Hermjakob, H, Rocca-Serra, P, Durand, G, Berjon, R, et al.. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6(1):28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, B, Rhodes, M and Thatcher, M (eds). 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? In Varieties of capitalism. The institutional foundations of comparative advantage. Edited by PA Hall and D Soskice. New York: Oxford University Press:184–213.

jime.csl Outdated
<title>Journal of Interactive Media in Education - Harvard</title>
<title-short>JIME - Harvard</title-short>
<id>http://www.zotero.org/styles/jime</id>
<link href="http://www.zotero.org/styles/jime" rel="self"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the ID and and self link in lines 6+7 to the following according to our submission guidelines:
..../harvard-journal-of-interactive-media-in-education (instead of the .../jime)

Please also change the actual file name to match that, with the .csl suffix

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed via 3ec264f

jime.csl Outdated
<label text-case="capitalize-first" variable="volume"/>
<text variable="volume"/>
</group>
<group font-variant="normal">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete any font-variant="normal" throughout the style unless it's on purpose.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any use of font-variant="normal" came from the template CSL used to start this file. I have removed references to it via 482b205, including reducing lines 153-155 by removing what seems like an unnecessary group to just have one line to call the editor-translator macro.

jime.csl Outdated
<choose>
<if type="book chapter thesis" match="none">
<choose>
<if variable="DOI">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can easily be simplified to the following as none of the groups do anything here and the DOI URI prefix should be closer to the variable anyway:


Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic came from the template CSL used to start this file. I didn’t see any provided example, but simplified the macro based on my understanding of what might be unnecessary via 926ef59.

@xolotl
Copy link
Author

xolotl commented Jan 20, 2025

Thank you for the careful review @POBrien333! I believe I have addressed all your suggestions, but the automated tests now seem to be failing with what may be an issue in the test code. I see error: "Run bundle exec sheldon --token=$GITHUB_TOKEN --failure --verbose
bundler: failed to load command: sheldon (/home/runner/work/styles/styles/vendor/bundle/ruby/3.0.0/bin/sheldon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants