fix(scripting/mono-v2): validate app domain before removing ref #2861
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix a crash that occurred when an export declared in lua code was executed from C# v2 from the same resource multiple times, the issue with more details is here: thorium-cfx/mono_v2_get_started#32
How is this PR achieving the goal
It seems that there are times that
m_appDomain
is destroyed when the script is stopped, but RemoveRef is still called a little after the C# script is destroyed, therefore RemoveRef is called whenm_appDomain
is null and results in the crash.I don't know if there is a better solution for this.
This PR applies to the following area(s)
ScRT: C#
Successfully tested on
Game builds: .
Platforms: Windows
Checklist
Fixes issues
fixes #32