Update device model queries to include relevant Variable Attribute type #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould also search only for variable attributes with a specific type (usually "Actual", but can be the other types as well)
lydiazcheng
approved these changes
Jan 16, 2025
| left join "Variables" v on va."variableId" = v."id" | ||
| left join "Components" c on va."componentId" = c."id" | ||
| left join "Evses" e on c."evseDatabaseId" = e."databaseId" | ||
| where va."stationId" = '${stationId}' and |
There was a problem hiding this comment.
One question: why does this query as well as query for evse_ids_string don't need to add va."type" = 'Actual' and?
There was a problem hiding this comment.
since it's the unique set of the evse ids, we don't necessarily have to target the type since if we pull let's say variable attributes of type Actual and Target with the same evse, they'll collapse into one evse in the set 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue citrineos/citrineos#98 - this PR adds an additional condition to the SQL queries that retrieve relevant device model information to also include the relevant Variable Attribute type.