Github action with Cypress #72
Conversation
| <Input | ||
| placeholder="Search" | ||
| onChange={handleSearchInputChange} | ||
| data-testId={`${dtoClass.name}-table-search`} |
There was a problem hiding this comment.
it may be better to use dtoResourceType instead of dtoClass.name to avoid the "Mysterious 2" that shows up. For example, MeterValues class would result in "MeterValues2"
There was a problem hiding this comment.
I can make that change in table-wrapper. But for instance inside the form getting to the submit button we don't have the resourceType. We would only have the parentRecord
src/components/tag/index.tsx
Outdated
| @@ -69,7 +69,7 @@ const GenericTag = <T extends Record<string, string | number>>({ | |||
| } | |||
|
|
|||
| return ( | |||
| <Tag color={color}> | |||
| <Tag color={color} data-testId="tag!"> | |||
There was a problem hiding this comment.
maybe we can use useId() hook so that we can have a unique id? I am worried bout this "tag" being in multiple places, also what's up with the exclamation at the end there? It seems that the exclamation will be part of the string?
There was a problem hiding this comment.
Yea, that was my oversight. I had gone down a rabbit hole and forgot to clean this up.
…estability with `data-testId`
… Fix linter error
ChrisWeissmann
force-pushed
the
feature/cypress-githubaction
branch
from
e01bba6 to
ba5af63
Compare
For now I had to add installing core manually until it's published.
Cypress runs with Chrome which should be sufficient for now.
Added some sample tests and added data-testId to identify the elements.