-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#1156): provide test api generator #1160
Closed
tschlat
wants to merge
8
commits into
citrusframework:main
from
postfinance:issue/1156/test_api_generator_TS
Closed
feat(#1156): provide test api generator #1160
tschlat
wants to merge
8
commits into
citrusframework:main
from
postfinance:issue/1156/test_api_generator_TS
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschlat
force-pushed
the
issue/1156/test_api_generator_TS
branch
from
May 15, 2024 05:27
4b7b9f9
to
e05ec95
Compare
bbortt
requested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huge @tschlat! I won't be nitpicking on this 🐤 but left some remarks.
core/citrus-api/src/main/java/org/citrusframework/testapi/GeneratedApi.java
Show resolved
Hide resolved
test-api-generator/citrus-test-api-generator-maven-plugin/pom.xml
Outdated
Show resolved
Hide resolved
test-api-generator/citrus-test-api-generator-maven-plugin/pom.xml
Outdated
Show resolved
Hide resolved
@tschlat awesome work! please bear with me as I need some more time to have a closer look |
tschlat
force-pushed
the
issue/1156/test_api_generator_TS
branch
from
May 21, 2024 04:58
50a7341
to
0b59743
Compare
bbortt
force-pushed
the
issue/1156/test_api_generator_TS
branch
2 times, most recently
from
July 3, 2024 06:24
fa99e36
to
b87c6b4
Compare
bbortt
force-pushed
the
issue/1156/test_api_generator_TS
branch
from
July 3, 2024 09:23
b87c6b4
to
d1b04d7
Compare
Closed in favor of: #1224 |
1 similar comment
Closed in favor of: #1224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added code for the test API generator plus documentation. The generator has been implemented having XML tests in mind. Therefore, usage within Java DSL is a little cumbersome and needs a rework. We propose to add this change as work in progress. It is quite isolated.
I have added #1161 and #1163 to finish this up.