Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving name and description about a popit api instance #861

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lfalvarez
Copy link
Member

This PR adds a method to all the PopitApiInstances out there so they can get information about what their name is and description, this PR will also store that information.

Unfortunately, the url cannot yet be determined correctly so you might be tempted to not accept this PR until we have that sorted out, the explanation for that problem can be found in get_about().

This also provides vcrpy to the tests which could probably help to solve #600.

This does not get the about your popit information when loading from popit.

So probably in order to finish #846 we would need to:

  • get the about your popit info when pulling from popit.
  • display the name and description in the Source Manager.

Please don't merge just yet I think it still needs some work.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.03% when pulling 2b09ff9 on issues/846/chicken-way into 3390598 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 98.6% when pulling 2b09ff9 on issues/846/chicken-way into 3390598 on master.

@chrismytton chrismytton force-pushed the issues/846/chicken-way branch from 2b09ff9 to 6f19ddc Compare April 15, 2015 15:10
@landscape-bot
Copy link

Code Health
Repository health decreased by 0.03% when pulling 6f19ddc on issues/846/chicken-way into baf97a3 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 98.63% when pulling 6f19ddc on issues/846/chicken-way into baf97a3 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 98.63% when pulling 6f19ddc on issues/846/chicken-way into baf97a3 on master.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.04% when pulling 2b11068 on issues/846/chicken-way into 154d8a9 on 1033-email-links-addresses.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2b11068 on issues/846/chicken-way into * on master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2b11068 on issues/846/chicken-way into * on master*.

…tance.py that was still there for some reason
@landscape-bot
Copy link

Code Health
Repository health increased by 0.01% when pulling 3d97456 on issues/846/chicken-way into 154d8a9 on 1033-email-links-addresses.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3d97456 on issues/846/chicken-way into * on master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3d97456 on issues/846/chicken-way into * on master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants