[Ref] [php8] Unshare shared function CRM_Custom_Form_CustomData::setGroupTree in order to clean-up

[eileenmcnaughton]

Overview

Unshare shared function CRM_Custom_Form_CustomData::setGroupTree in order to clean-up

Before

CRM_Custom_Form_CustomData::setGroupTree is shared for the purposes of re-using the CustomData form code in other forms - but it expects all sorts of variables to be passed via form properties that are relevant to the original class rather than the forms - so a tonne of work is done to re-use it

After

The 2 places that use it have their own copies (one copied inline into the calling function). It is deprecated

Technical Details

Towards fixing https://test.civicrm.org/job/CiviCRM-Core-Edge/CIVIVER=master,label=bknix-tmp-edge/2843/testReport/junit/(root)/CRM_Contact_Form_Task_AddToGroupTest/testAddToGroup/

Comments

I created an issue on gdpr veda-consulting-company/uk.co.vedaconsulting.gdpr#330

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[seamuslee001]

ok this seems fine

[eileenmcnaughton]

thanks @seamuslee001