This repository has been archived by the owner on Aug 29, 2020. It is now read-only.
Implement #148 and #149 #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whuang8
reviewed
Aug 14, 2019
There was a problem hiding this comment.
There is a NetInterface type aliased to string in this file as well. Given changes from string to []string in the rest of the PR, this alias should change as well.
However, I don't see the NetInterface type being used anywhere in the project. Can you delete this type alias in order to remove some confusion?
whuang8
reviewed
Aug 14, 2019
| @@ -112,7 +112,7 @@ To make a custom colorscheme, check out the [template](./colorschemes/template.g | |||
| `-p`, `--percpu` Show each CPU in the CPU widget. | |||
| `-a`, `--averagecpu` Show average CPU in the CPU widget. | |||
| `-s`, `--statusbar` Show a statusbar with the time. | |||
| `-b`, `--battery` Show battery level widget (`minimal` turns off). [preview](./assets/screenshots/battery.png) | |||
| `-b`, `--battery` Show battery level widget (`minimal` turns off). [preview](./assets/screenshots/battery.png) | |||
| `-i`, `--interface=NAME` Select network interface [default: all]. | |||
There was a problem hiding this comment.
I think it would be a good idea to let users know in the readme that many interfaces can be defined with CSVs and that interfaces can be ignored with !
The same documentation should also appear in the cli usage text
This was referenced Feb 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement #148 and #149