Bugfix for saveChanges check

cjmalloy · Dec 13, 2024 · d6299c3 · d6299c3
1 parent df9f4d4
commit d6299c3
Show file tree

Hide file tree

Showing 26 changed files with 30 additions and 29 deletions.
diff --git a/src/app/component/comment/comment.component.ts b/src/app/component/comment/comment.component.ts
@@ -121,9 +121,9 @@ export class CommentComponent implements OnInit, AfterViewInit, OnChanges, OnDes
   }
 
   saveChanges() {
-    return !!this.editComponent?.saveChanges()
-      && !!this.replyComponent?.saveChanges()
-      && !!this.threadComponent?.saveChanges();
+    return (!this.editComponent || this.editComponent.saveChanges())
+      && (!this.replyComponent || this.replyComponent.saveChanges())
+      && (!this.threadComponent || this.threadComponent.saveChanges());
   }
 
   ngOnInit(): void {

diff --git a/src/app/component/graph/force-directed/force-directed.component.ts b/src/app/component/graph/force-directed/force-directed.component.ts
@@ -122,7 +122,7 @@ export class ForceDirectedComponent implements AfterViewInit, OnDestroy, HasChan
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnDestroy() {

diff --git a/src/app/component/ref/ref.component.ts b/src/app/component/ref/ref.component.ts
@@ -212,7 +212,7 @@ export class RefComponent implements OnChanges, AfterViewInit, OnDestroy, HasCha
 
   saveChanges() {
     return (!this.editing || !this.editForm.dirty)
-      && (!this.replying || !!this.reply?.saveChanges());
+      && (!this.reply || this.reply.saveChanges());
   }
 
   init() {

diff --git a/src/app/guard/pending-changes.guard.ts b/src/app/guard/pending-changes.guard.ts
@@ -6,5 +6,5 @@ export interface HasChanges {
 
 export const pendingChangesGuard: CanDeactivateFn<HasChanges> = (component, currentRoute, currentState, nextState) => {
   if (!component?.saveChanges || component.saveChanges()) return true;
-   return confirm($localize`Discard draft?`);
+  return confirm($localize`Discard draft?`);
 };
diff --git a/src/app/page/home/home.component.ts b/src/app/page/home/home.component.ts
@@ -40,7 +40,7 @@ export class HomePage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.lens?.saveChanges();
+    return !this.lens || this.lens.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/inbox/alarms/alarms.component.ts b/src/app/page/inbox/alarms/alarms.component.ts
@@ -35,7 +35,7 @@ export class InboxAlarmsPage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/inbox/all/all.component.ts b/src/app/page/inbox/all/all.component.ts
@@ -35,7 +35,7 @@ export class InboxAllPage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/inbox/dms/dms.component.ts b/src/app/page/inbox/dms/dms.component.ts
@@ -35,7 +35,7 @@ export class InboxDmsPage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/inbox/modlist/modlist.component.ts b/src/app/page/inbox/modlist/modlist.component.ts
@@ -37,7 +37,7 @@ export class InboxModlistPage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/inbox/ref/ref.component.ts b/src/app/page/inbox/ref/ref.component.ts
@@ -37,7 +37,7 @@ export class InboxRefPage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/inbox/reports/reports.component.ts b/src/app/page/inbox/reports/reports.component.ts
@@ -37,7 +37,7 @@ export class InboxReportsPage  implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/inbox/sent/sent.component.ts b/src/app/page/inbox/sent/sent.component.ts
@@ -35,7 +35,7 @@ export class InboxSentPage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/ref/alts/alts.component.ts b/src/app/page/ref/alts/alts.component.ts
@@ -37,7 +37,7 @@ export class RefAltsComponent implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/ref/comments/comments.component.ts b/src/app/page/ref/comments/comments.component.ts
@@ -37,7 +37,7 @@ export class RefCommentsComponent implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.reply?.saveChanges();
+    return !this.reply || this.reply.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/ref/errors/errors.component.ts b/src/app/page/ref/errors/errors.component.ts
@@ -48,7 +48,7 @@ export class RefErrorsComponent implements HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/ref/responses/responses.component.ts b/src/app/page/ref/responses/responses.component.ts
@@ -33,7 +33,7 @@ export class RefResponsesComponent implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/ref/sources/sources.component.ts b/src/app/page/ref/sources/sources.component.ts
@@ -37,7 +37,7 @@ export class RefSourcesComponent implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/ref/summary/summary.component.ts b/src/app/page/ref/summary/summary.component.ts
@@ -54,8 +54,8 @@ export class RefSummaryComponent implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.reply?.saveChanges()
-      && !!this.list?.saveChanges()
+    return (!this.reply || this.reply.saveChanges())
+      && (!this.list || this.list.saveChanges())
       && !this.threadComponents?.find(t => !t.saveChanges());
   }
 

diff --git a/src/app/page/ref/thread/thread.component.ts b/src/app/page/ref/thread/thread.component.ts
@@ -55,7 +55,8 @@ export class RefThreadComponent implements HasChanges {
   }
 
   saveChanges() {
-    return !!this.reply?.saveChanges() && !!this.list?.saveChanges();
+    return (!this.reply || this.reply.saveChanges())
+      && (!this.list || this.list.saveChanges());
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/ref/versions/versions.component.ts b/src/app/page/ref/versions/versions.component.ts
@@ -33,7 +33,7 @@ export class RefVersionsComponent implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/settings/plugin/plugin.component.ts b/src/app/page/settings/plugin/plugin.component.ts
@@ -42,7 +42,7 @@ export class SettingsPluginPage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/settings/ref/ref.component.ts b/src/app/page/settings/ref/ref.component.ts
@@ -39,7 +39,7 @@ export class SettingsRefPage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/settings/template/template.component.ts b/src/app/page/settings/template/template.component.ts
@@ -41,7 +41,7 @@ export class SettingsTemplatePage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/settings/user/user.component.ts b/src/app/page/settings/user/user.component.ts
@@ -39,7 +39,7 @@ export class SettingsUserPage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {

diff --git a/src/app/page/tag/tag.component.ts b/src/app/page/tag/tag.component.ts
@@ -63,7 +63,7 @@ export class TagPage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.lens?.saveChanges();
+    return !this.lens || this.lens.saveChanges();
   }
 
   ngOnInit() {

diff --git a/src/app/page/tags/tags.component.ts b/src/app/page/tags/tags.component.ts
@@ -44,7 +44,7 @@ export class TagsPage implements OnInit, OnDestroy, HasChanges {
   }
 
   saveChanges() {
-    return !!this.list?.saveChanges();
+    return !this.list || this.list.saveChanges();
   }
 
   ngOnInit(): void {