Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new-logic 3/X: Reactive settings #163

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

robojumper
Copy link
Contributor

@robojumper robojumper commented Mar 8, 2024

Based on #162, see compare view for just this PR's changes.

  • Decapsulates the Requirements data
  • Parse logic without access to current settings, separately create settings tweaks to merge in a selector
    • This will allow changing settings at runtime
  • Removes the LogicHelper class and bind dependency injection to make data flow explicit
    • This revealed some dead/unnecessarily complicated code, such as the call to BooleanExpression.reduce and the intermediate data type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant