Replace lodash-es with es-toolkit/compat
#17872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipsobol
commented
Feb 3, 2025
| @@ -176,7 +176,7 @@ describe( 'ImageStyleEditing', () => { | |||
| plugins: [ ImageBlockEditing, ImageStyleEditing ] | |||
| } ); | |||
|
|
|||
| sinon.assert.calledOnceWithMatch( normalizationSpy, { | |||
| expect( normalizationSpy.firstCall.args[ 0 ] ).to.deep.equal( { | |||
There was a problem hiding this comment.
This change is related to toss/es-toolkit#953 because sinon internally tries to use toString which is not available. IMO, current es-toolkit behavior makes more sense than in lodash-es.
filipsobol
commented
Feb 3, 2025
| @@ -308,7 +307,7 @@ export default class ImageResizeButtons extends Plugin { | |||
| } ) | |||
| }; | |||
|
|
|||
| const allDropdownValues = map( optionsWithSerializedValues, 'valueWithUnits' ); | |||
| const allDropdownValues = Object.values( optionsWithSerializedValues ).map( option => option.valueWithUnits ); | |||
There was a problem hiding this comment.
This is the same, so let's just use native APIs.
arkflpc
previously approved these changes
Feb 3, 2025
arkflpc
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Replace
lodash-eswithes-toolkit. See #16395.You can find more information about why we made this change here: #16395 (comment)