Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TypeScript target to es2022. #17885

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Update TypeScript target to es2022. #17885

merged 2 commits into from
Feb 7, 2025

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Feb 5, 2025 •
edited
Loading

Suggested merge commit message (convention)

Other: Update TypeScript target to es2022. Closes #17886.

pomek
pomek approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

psmyrek
psmyrek approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many more places where the ?. operator could be used.

I assume we want to update only a few places just for testing purposes.

@filipsobol filipsobol merged commit 57c46c8 into master-it84 Feb 7, 2025
8 checks passed
@filipsobol filipsobol deleted the update-target-to-es2022 branch February 7, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomek pomek pomek approved these changes

@psmyrek psmyrek psmyrek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipsobol @pomek @psmyrek