Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about CDN use in Emoji plugin #17902

Merged
merged 10 commits into from
Feb 11, 2025
Merged

Warn about CDN use in Emoji plugin #17902

merged 10 commits into from
Feb 11, 2025

Conversation

filipsobol
Copy link
Member

Suggested merge commit message (convention)

Internal (emoji): Add the definitionsUrl configuration option.

Internal (emoji): Add the emoji-repository-redundant-version warning.

Internal (emoji): Add the emoji-repository-cdn-use warning.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@filipsobol filipsobol changed the title Warn about cdn use in emoji Warn about CDN use in Emoji plugin Feb 10, 2025
@pomek pomek requested a review from psmyrek February 10, 2025 13:23
@filipsobol filipsobol requested a review from godai78 February 10, 2025 15:28
psmyrek
psmyrek reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works 🎉

Manual test currently allows configuring supported options in the test itself. Do we want to add the ability to provide custom URL as well?

packages/ckeditor5-emoji/src/emojiconfig.ts Outdated Show resolved Hide resolved
packages/ckeditor5-emoji/src/emojiconfig.ts Outdated Show resolved Hide resolved
packages/ckeditor5-emoji/src/emojirepository.ts Outdated Show resolved Hide resolved
packages/ckeditor5-emoji/src/emojirepository.ts Outdated Show resolved Hide resolved
@filipsobol filipsobol requested a review from psmyrek February 11, 2025 08:55
@pomek pomek merged commit cc45f55 into release Feb 11, 2025
9 checks passed
@pomek pomek deleted the warn-about-cdn-use-in-emoji branch February 11, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorzelinski gorzelinski gorzelinski approved these changes

@godai78 godai78 Awaiting requested review from godai78

@psmyrek psmyrek Awaiting requested review from psmyrek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filipsobol @gorzelinski @psmyrek @pomek