[WIP] Docs: Use CDN build and importmap in snippets. #17929
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipsobol
commented
Feb 14, 2025
| import { CKEditorTranslationsPlugin } from '@ckeditor/ckeditor5-dev-translations'; | ||
| import MiniCssExtractPlugin from 'mini-css-extract-plugin'; | ||
| import TerserPlugin from 'terser-webpack-plugin'; | ||
| import { createRequire } from 'module'; |
There was a problem hiding this comment.
Only this file has some notable changes. Changes in all other files should be:
- typo fixes,
- import fixes,
- removal of license keys from snippets.
Witoso
reviewed
Feb 14, 2025
scripts/docs/snippetadapter.mjs
Outdated
Comment on lines
76
to
77
| '<link rel="stylesheet" href="https://cdn.ckeditor.com/ckeditor5/44.2.0/ckeditor5.css" />', | ||
| '<link rel="stylesheet" href="https://cdn.ckeditor.com/ckeditor5-premium-features/44.2.0/ckeditor5-premium-features.css" />', |
There was a problem hiding this comment.
Shouldn't these be based on the version as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Docs: Use CDN build and importmap in snippets.