Skip to content

Commit

Permalink
Revert to Node 18 for testing
Browse files Browse the repository at this point in the history
  • Loading branch information
claabs committed Feb 28, 2024
1 parent cb22830 commit a6a9b88
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
18
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
########
# BASE
########
FROM node:20-alpine3.19 as base
FROM node:18-alpine3.19 as base

ENV DISTRO=alpine
ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1
Expand Down Expand Up @@ -71,7 +71,7 @@ LABEL org.opencontainers.image.title="epicgames-freegames-node" \
org.opencontainers.image.name="epicgames-freegames-node" \
org.opencontainers.image.revision=${COMMIT_SHA} \
org.opencontainers.image.ref.name=${BRANCH} \
org.opencontainers.image.base.name="node:20-alpine3.19" \
org.opencontainers.image.base.name="node:18-alpine3.19" \
org.opencontainers.image.version="latest"

ENV NODE_ENV=production \
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.debian
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
########
# BASE
########
FROM node:20-bookworm-slim as base
FROM node:18-bookworm-slim as base

ENV DISTRO=debian
ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1
Expand Down Expand Up @@ -76,7 +76,7 @@ LABEL org.opencontainers.image.title="epicgames-freegames-node" \
org.opencontainers.image.name="epicgames-freegames-node" \
org.opencontainers.image.revision=${COMMIT_SHA} \
org.opencontainers.image.ref.name=${BRANCH} \
org.opencontainers.image.base.name="node:20-bookworm-slim" \
org.opencontainers.image.base.name="node:18-bookworm-slim" \
org.opencontainers.image.version="debian"

ENV NODE_ENV=production \
Expand Down
2 changes: 1 addition & 1 deletion Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ If for some reason you don't want to use Docker to run this tool you can run it
* Or download and unpack ZIP archive: [epicgames-freegames-node](https://github.com/claabs/epicgames-freegames-node/archive/master.zip)
1. Create `config` folder in the cloned/unpacked directory
1. Create [JSON configuration](#json-configuration)
1. [Install Node.js 20](https://nodejs.org/) or higher
1. [Install Node.js 18](https://nodejs.org/) or higher
1. Install Node.js dependencies
* Start terminal and navigate to cloned/unpacked directory
* Run `npm i`
Expand Down
34 changes: 17 additions & 17 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,12 @@
"url-join": "^5.0.0"
},
"devDependencies": {
"@tsconfig/node20": "^20.1.2",
"@tsconfig/node18": "^18.2.2",
"@tsconfig/strictest": "^2.0.3",
"@types/express": "^4.17.21",
"@types/fs-extra": "^11.0.4",
"@types/localtunnel": "^2.0.4",
"@types/node": "^20.11.20",
"@types/node": "^18.19.20",
"@types/nodemailer": "^6.4.14",
"@types/object-assign-deep": "^0.4.3",
"@types/set-cookie-parser": "^2.4.7",
Expand All @@ -79,7 +79,7 @@
"vite-node": "^1.3.1"
},
"engines": {
"node": ">=20"
"node": ">=18"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"extends": [
"@tsconfig/strictest/tsconfig",
"@tsconfig/node20/tsconfig",
"@tsconfig/node18/tsconfig",
],
"compilerOptions": {
// ESM
Expand Down

0 comments on commit a6a9b88

Please sign in to comment.