Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Prevent createdA being updated on upsert (updateOrCreate) call #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kno
Copy link

@kno kno commented Oct 14, 2016

#11

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 15f8402 on kno:createdat_problem_solved into 9051e93 on clarkbw:master.

@clarkbw
Copy link
Owner

clarkbw commented Oct 20, 2016

@kno why does this solve the problem? The tests seem to pass but I believe we need a test that is specific to this change.

@clarkbw
Copy link
Owner

clarkbw commented Oct 20, 2016

The test should turn on validation and upsert fails should be failing if this change fixes the issue.

@anselanza
Copy link

Eek, would love for this to be fixed. Not merged yet?

@kno
Copy link
Author

kno commented Feb 14, 2017

I'm not familiar with travis, and is failing. Can anyone tell me why?

@clarkbw
Copy link
Owner

clarkbw commented Feb 16, 2017

That test should be failing locally as well as on travis. I believe this is an issue with the change, not travis itself.

@kno kno closed this Feb 16, 2017
@kno kno reopened this Feb 16, 2017
@coveralls
Copy link

coveralls commented Feb 16, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 15f8402 on kno:createdat_problem_solved into 9051e93 on clarkbw:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants