Change the param type for CreateTask from value to pointer

claudealdric · Sep 16, 2024 · d8c416d · d8c416d
1 parent 2e5fa37
commit d8c416d
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/api/post_task_handler.go b/api/post_task_handler.go
@@ -16,7 +16,7 @@ func (s *Server) HandlePostTask(w http.ResponseWriter, r *http.Request) {
 		http.Error(w, err.Error(), http.StatusBadRequest)
 		return
 	}
-	task, err := s.store.CreateTask(dto)
+	task, err := s.store.CreateTask(&dto)
 	if err != nil {
 		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return

diff --git a/data/file_system_store.go b/data/file_system_store.go
@@ -68,7 +68,7 @@ func (f *FileSystemStore) GetTasks() ([]models.Task, error) {
 	return tasks, nil
 }
 
-func (f *FileSystemStore) CreateTask(dto models.CreateTaskDTO) (*models.Task, error) {
+func (f *FileSystemStore) CreateTask(dto *models.CreateTaskDTO) (*models.Task, error) {
 	tasks, err := f.GetTasks()
 	if err != nil {
 		return nil, err

diff --git a/data/file_system_store_test.go b/data/file_system_store_test.go
@@ -75,7 +75,7 @@ func TestFileSystemStoreTasks(t *testing.T) {
 
 		assert.HasNoError(t, err)
 
-		newTask, err := store.CreateTask(models.CreateTaskDTO{"Launder clothes"})
+		newTask, err := store.CreateTask(&models.CreateTaskDTO{"Launder clothes"})
 		assert.HasNoError(t, err)
 
 		tasks, err := store.GetTasks()

diff --git a/data/store.go b/data/store.go
@@ -9,7 +9,7 @@ import (
 var ErrResourceNotFound = errors.New("resource not found")
 
 type Store interface {
-	CreateTask(dto models.CreateTaskDTO) (*models.Task, error)
+	CreateTask(dto *models.CreateTaskDTO) (*models.Task, error)
 	DeleteTaskById(id int) error
 	GetTaskById(id int) (models.Task, error)
 	GetTasks() ([]models.Task, error)

diff --git a/testutils/mock_store.go b/testutils/mock_store.go
@@ -36,7 +36,7 @@ func NewMockStore(shouldError bool) *mockStore {
 	return m
 }
 
-func (m *mockStore) CreateTask(dto models.CreateTaskDTO) (*models.Task, error) {
+func (m *mockStore) CreateTask(dto *models.CreateTaskDTO) (*models.Task, error) {
 	m.CreateTaskCalls++
 	if m.shouldForceError {
 		return nil, forcedError