Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias func #1

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

EduardZaydler
Copy link

@EduardZaydler EduardZaydler commented Jul 28, 2024

This PR adds alias VM function to the metrcsql codemirror mode
image

@EduardZaydler
Copy link
Author

@clavinjune, hello! Could you take a look at this, please?

@clavinjune clavinjune self-requested a review July 29, 2024 07:24
@clavinjune clavinjune merged commit fe682e4 into clavinjune:main Jul 29, 2024
10 of 18 checks passed
@EduardZaydler
Copy link
Author

EduardZaydler commented Jul 29, 2024

@clavinjune, also would appreciate if you push new version to npm registry, or i can try to do it myself (possibly will need help)

@clavinjune
Copy link
Owner

clavinjune commented Jul 29, 2024

sure, I'll do this tomorrow @EduardZaydler

@clavinjune
Copy link
Owner

clavinjune commented Jul 30, 2024

pushed to npm @EduardZaydler with version 0.0.1-dev.3007240001 https://www.npmjs.com/package/@clavinjune/codemirror-metricsql

@EduardZaydler
Copy link
Author

EduardZaydler commented Jul 30, 2024

@clavinjune sorry for disturbing, but run into an error in parser.js when trying to call func
image
image

but locally when was adding this in your repo everything was fine
probably i should've add it to isFunctionBypassed list, am i right?

added fixing pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants