Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement fromCallback for node-style callbacks #16

Merged
merged 6 commits into from
May 7, 2024
Merged

feat: implement fromCallback for node-style callbacks #16

merged 6 commits into from
May 7, 2024

Commits on May 7, 2024

  1. create a utility method to turn a node style callback into a promise

    @andogq
    andogq committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bfed75e View commit details
    Browse the repository at this point in the history

  2. implement fromCallback

    @andogq
    andogq committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3957848 View commit details
    Browse the repository at this point in the history

  3. add some tests for fromCallback

    @andogq
    andogq committed May 7, 2024
    Configuration menu
    Copy the full SHA
    064cf11 View commit details
    Browse the repository at this point in the history

  4. add changeset

    @andogq
    andogq committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3ce4ff3 View commit details
    Browse the repository at this point in the history

  5. add an example to fromCallback

    @andogq
    andogq committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7fe9df1 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Ewan Breakey <[email protected]>
    @andogq @giraugh
    andogq and giraugh authored May 7, 2024
    Configuration menu
    Copy the full SHA
    d7a7c42 View commit details
    Browse the repository at this point in the history