Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.3.1 docs update #27

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

V2.3.1 docs update #27

wants to merge 58 commits into from

Conversation

thejspr
Copy link
Contributor

@thejspr thejspr commented May 23, 2024

  • Adds v2.3.1.1 spec api documentation.
  • Adds v2.3.1.1 specs
  • A lot of the diff is the generated stuff in source/_static is formatting and indentation.
  • Updated to latest shinx-docs, which prints missing references etc.

Status 09-10-2024: Awaiting 2.3.1 certification with major schemes before merging. ETA unknown.

@thejspr thejspr marked this pull request as ready for review May 29, 2024 06:34
@thejspr thejspr changed the base branch from master to prettier-docs May 29, 2024 12:48
Comment on lines 3 to 18
3-D Secure version determination
================================

There are currently three 3-D Secure versions, ``1.0.2``, ``2.1.0`` and ``2.2.0``.
There are currently three 3-D Secure versions, ``2.1.0``, ``2.2.0`` and ``2.3.1.1``.

1. If the :ref:`preauth call <preauth-usage>` returns a :ref:`not_enrolled`, continue with 3DSv1.
2. If ``acsInfoInd`` (`2.1.0
<specification_210.html#attr-cardRangeData-acsInfoInd>`_, `2.2.0
<specification_220.html#attr-cardRangeData-acsInfoInd>`_) is included, this
indicates if ACS supports challenges or only attempts.
2. If ``acsInfoInd``
(`2.1.0 <specification_210.html#attr-CRD-acsInfoInd>`_,
`2.2.0 <specification_220.html#attr-CRD-acsInfoInd>`_,
`2.3.1.1 <specification_2311.html#attr-CRD-acsInfoInd>`_)
is included, this indicates if ACS supports challenges or only attempts.

To select between ``2.1.0`` and ``2.2.0``, we suggest using the highest version
To select between ``2.1.0``, ``2.2.0`` and ``2.3.1.1``, we suggest using the highest version
that all parties support, including your implementation. Exemplified:

- If ``dsEndProtocolVersion: 2.2.0`` and ``acsEndProtocolVersion: 2.1.0``, then the ACS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to reconsider this part a bit.
Depends on how the preauth response will be.
I believe @kbadk and I will have a talk about the preauth response.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to specify 2.3.1.1? Wouldn't 2.3.1 be sufficient?

source/reference.rst Outdated Show resolved Hide resolved
@Lassejoe
Copy link
Contributor

Lassejoe commented Jun 3, 2024

@thejspr wrt. to the comments about the AReq remember the links shall also be changed.

@Lassejoe
Copy link
Contributor

Lassejoe commented Jun 3, 2024

@thejspr I don't have much more than my comments above :)

@thejspr
Copy link
Contributor Author

thejspr commented Jun 3, 2024

@Lassejoe the links to specific specs was manually edited and is quite a chore to do and will get overwritten when we generate the docs.

}
]
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self @thejspr : Update once settle on a final structure.

@@ -17,7 +17,7 @@ If `3DS Method URL`_ is included in the :ref:`preauth-usage` response, the
3DS method *must* be invoked as explained in this guide.

If ``threeDSMethodURL`` *is not* included in the ``/preauth`` response (ref.
:ref:`2.1.0 <preauth-response-210>`, :ref:`2.1.0 <preauth-response-220>`),
:ref:`2.1.0 <preauth-response-210>`, :ref:`2.2.0 <preauth-response-220>`, :ref:`2.3.1 <preauth-response-231>`),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably omit 2.1.0 since it will be gone by the time this documentation is released?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the size of this PR, i think it will make sense to remove 2.1 in a separate PR

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

source/_static/creq.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants