Implement building multithreaded for windows. #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nouwaarom
force-pushed
the
enhancement/multithreaded-windows
branch
from
be2b292
to
3a69d87
Compare
nouwaarom
force-pushed
the
enhancement/multithreaded-windows
branch
from
3a69d87
to
80fbe1b
Compare
nouwaarom
changed the title
jwerle
added
enhancement
windows
|
Do you know what happened to the macOS tests? It seems like they got stuck |
Not sure but we can address in isolation in a separate PR |
Unfortunately the MacOS tests are failing for a while now #237 |
Same here :( |
|
@nouwaarom we can merge this PR as is, for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that it should be possible to make the windows builds multi threaded as well.