Update Point.php to update dimension when using setAltitude #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue that setAltitude didn't update the points dimension.
Updated Changelog according to fix for not updating points dimension.
saibotk
approved these changes
Jul 4, 2024
|
Can you fix the linting errors? |
|
Thank you for your quick response. :) |
saibotk
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue by converting a LineString object via the WKTGenerator to a wkt string. Even though every point has a z value the value is not included in the resulting converted wkt string.
Before the converting is done I am setting new altitude / z values for each point via the setAltitude function. I saw that this function doesn't call the updateDimension function like setZ function would do. When I use the setZ function everything works fine. So I changed the setAltitude function to call the internal setZ function and made this logical change to setLatitude and setLongitude as well.
I hope I have done everything right because this is my first pull request.
Please let me know if I made any mistakes.