Backport upstream changes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to make this gem compatible with Ruby 2.2
Change time_ago_in_words implementation. Using this smaller gem will make it easier to support `ten_years_rails` with older versions of Ruby.
Also, add `timecop` dependency to test time sensitive specs
This will make it a little easier to add test coverage for `GemInfo` and `BundleReport` Also, I removed unused methods and made `time_ago_in_words` a little smarter so that it doesn't depend on `ActionView` helpers
I really need to have some of the changes that have been submitted to https://github.com/clio/ten_years_rails, so I've decided to launch a gem so that I can use it in an upcoming workshop
Update homepage in gemspec
doliveirakn
approved these changes
Dec 5, 2019
arthurchui
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges all the upstream changes from next_rails/master. Thanks @etagwerker for all your great work on the gem! 🎉
Among other things, this addresses the changes proposed in #14 and #17.
References to
next_rails/NextRailshave been adjusted toten_years_rails/TenYearsRailsto keep things consistent with this gem's name.